Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed up the mock tests #1103

Merged
merged 1 commit into from
May 18, 2021
Merged

speed up the mock tests #1103

merged 1 commit into from
May 18, 2021

Conversation

marten-seemann
Copy link
Contributor

It's probably not worth spending more than a minute on this single test case.

Stebalien
Stebalien requested changes May 18, 2021
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this seems fine. Note: this is testing the mock network, so it's not super critical regardless.

p2p/net/mock/mock_test.go Outdated Show resolved Hide resolved
@Stebalien Stebalien merged commit a26ef70 into master May 18, 2021
@Stebalien Stebalien deleted the speedup-mock-test branch May 18, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @Stebalien